Updates specs to run on newer ruby versions, adds CGI.unescape to request.fullpath#108
Updates specs to run on newer ruby versions, adds CGI.unescape to request.fullpath#108stas merged 2 commits intostas:masterfrom
Conversation
…the request.fullpath has been sent escaped
code-bunny
changed the title
There was a problem hiding this comment.
Agreed, I also had to increase the sqlite3 version.
There was a problem hiding this comment.
Correct, as seen in the screenshot request.fullpath is un-escaped, adding CGI.unescape resolves this gap:
I added puts debug statements to print the link without CGI.unescape (current code) and with CGI.unescape (proposed change).
There was a problem hiding this comment.
Agreed, I had to remove this line too to get the command rake spec to work without errors.
I also suggest an additional change:
SamuelB-MT
left a comment
SamuelB-MT
left a comment
There was a problem hiding this comment.
In my opinion these changes are valid, as I ran into similar problems and ended up with the same solution prior to checking this PR.
There was a problem hiding this comment.
I was getting several instances of the warning: Status code :unprocessable_entity is deprecated and will be removed in a future version of Rack. Please use :unprocessable_content instead.
This change removes said warning.
|
Thank you folks for reviewing this! |
3 participants
What is the current behaviour?
What is the new behaviour?
Checklist
Please make sure the following requirements are complete:
features)